Skip to content

Fix H265Payloader#350

Merged
Juliapixel merged 1 commit intomasterfrom
h265-payloader-fix
Jan 4, 2026
Merged

Fix H265Payloader#350
Juliapixel merged 1 commit intomasterfrom
h265-payloader-fix

Conversation

@Juliapixel
Copy link
Member

@Juliapixel Juliapixel commented Jan 4, 2026

Description

Follow-up of #348

Replaces the previous H265Payloader implementation, fixes broken packetization. Tested to work on chrome.

Reference issue

Fixes #309
Fixes pion/webrtc#3137

@codecov
Copy link

codecov bot commented Jan 4, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.58%. Comparing base (1461347) to head (bfca89f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
codecs/h265_packet.go 57.14% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (57.14%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
+ Coverage   81.93%   82.58%   +0.64%     
==========================================
  Files          28       28              
  Lines        3527     3428      -99     
==========================================
- Hits         2890     2831      -59     
+ Misses        456      427      -29     
+ Partials      181      170      -11
Flag Coverage Δ
go 82.58% <57.14%> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

JoTurk
JoTurk approved these changes Jan 4, 2026
View reviewed changes
Copy link
Member

@JoTurk JoTurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tested this with chrome and gstreamer and works as expected, also confirmed that it fixes the artifacts with the old paylaoder.

the new payloader here was actually added in julia's previous commit 5cd305b
DONL writing was incorrect so Julia disabled it. Old impl just advanced DONL every FU and it didn't provide an API to actually pass it from the encoder.

@Juliapixel Juliapixel merged commit 1edc72d into master Jan 4, 2026
18 of 19 checks passed
@Juliapixel Juliapixel deleted the h265-payloader-fix branch January 4, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoTurk JoTurk JoTurk approved these changes

@philipch07 philipch07 Awaiting requested review from philipch07

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HEVC/h265 doesn't work properly H265Packet can't work properly with pion/webrtc SampleBuilder

2 participants

@Juliapixel @JoTurk